Fix typing problems in OC_Image

Signed-off-by: Côme Chilliet <[email protected]>
nextcloud · Dec 6, 2021 · d1e0aee · d1e0aee
1 parent d2b6733
commit d1e0aee
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/private/legacy/OC_Image.php b/lib/private/legacy/OC_Image.php
@@ -124,7 +124,11 @@ public function mimeType() {
 	 * @return int
 	 */
 	public function width() {
-		return $this->valid() ? imagesx($this->resource) : -1;
+		if ($this->valid() && (($width = imagesx($this->resource)) !== false)) {
+			return $width;
+		} else {
+			return -1;
+		}
 	}
 
 	/**
@@ -133,7 +137,11 @@ public function width() {
 	 * @return int
 	 */
 	public function height() {
-		return $this->valid() ? imagesy($this->resource) : -1;
+		if ($this->valid() && (($height = imagesy($this->resource)) !== false)) {
+			return $height;
+		} else {
+			return -1;
+		}
 	}
 
 	/**

diff --git a/lib/public/IImage.php b/lib/public/IImage.php
@@ -98,7 +98,7 @@ public function show($mimeType = null);
 	public function save($filePath = null, $mimeType = null);
 
 	/**
-	 * @return resource|\GdImage Returns the image resource in any.
+	 * @return false|resource|\GdImage Returns the image resource if any
 	 * @since 8.1.0
 	 */
 	public function resource();