Skip to content

Commit

Permalink
additional logging when mkdir fails for object storage
Browse files Browse the repository at this point in the history
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
icewind1991 committed Apr 5, 2023
1 parent a1b7f13 commit c6be96d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/private/Files/ObjectStore/ObjectStoreStorage.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public function __construct($params) {
public function mkdir($path) {
$path = $this->normalizePath($path);
if ($this->file_exists($path)) {
$this->logger->warning("Tried to create an object store folder that already exists: $path");
return false;
}

Expand All @@ -120,10 +121,12 @@ public function mkdir($path) {
if ($parentType === false) {
if (!$this->mkdir($parent)) {
// something went wrong
$this->logger->warning("Parent folder ($parent) doesn't exist and couldn't be created");
return false;
}
} elseif ($parentType === 'file') {
// parent is a file
$this->logger->warning("Parent ($parent) is a file");
return false;
}
// finally create the new dir
Expand Down

0 comments on commit c6be96d

Please sign in to comment.