Skip to content

Commit

Permalink
Remove no longer needed CSS rules
Browse files Browse the repository at this point in the history
Since Nextcloud 22 the "#new-user" rules had no effect, as the DOM
structure changed to show a dialog rather than adding a row on top of
the list when adding new users.

Similarly, the z-index was no longer needed, as there will be no
"new-user" row that could overlap. Moreover, the z-index was set even
higher (100) in another rule still active.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
danxuliu committed Dec 9, 2021
1 parent aa8b11c commit bf499c0
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions apps/settings/css/settings.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1549,8 +1549,7 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
}

/* various */
&#grid-header,
&#new-user {
&#grid-header {
@include position('sticky');
align-self: normal;
background-color: var(--color-main-background);
Expand All @@ -1562,18 +1561,8 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
}
}

// separate prop to set initial value to top: 50px
&#new-user {
height: 120px;

.row {
padding-top: 50px;
}
}

&#grid-header {
color: var(--color-text-maxcontrast);
z-index: 60; /* above new-user */
border-bottom-width: thin;

#headerDisplayName,
Expand Down

0 comments on commit bf499c0

Please sign in to comment.