remove file exists check from cacheAndReturnMimeType

the method is only called if the file exists already a check against storing the fallback mimetype is added as a safety instead Signed-off-by: Robin Appelman <[email protected]>
nextcloud · Dec 20, 2022 · 83cc820 · 83cc820
1 parent c5a8246
commit 83cc820
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/apps/workflowengine/lib/Check/FileMimeType.php b/apps/workflowengine/lib/Check/FileMimeType.php
@@ -77,7 +77,7 @@ public function setFileInfo(IStorage $storage, string $path, bool $isDir = false
 	}
 
 	/**
-	 * The mimetype is only cached if the file exists. Otherwise files access
+	 * The mimetype is only cached if the file has a valid mimetype. Otherwise files access
 	 * control will cache "application/octet-stream" for all the target node on:
 	 * rename, move, copy and all other methods which create a new item
 	 *
@@ -92,7 +92,7 @@ public function setFileInfo(IStorage $storage, string $path, bool $isDir = false
 	 * @return string
 	 */
 	protected function cacheAndReturnMimeType(string $storageId, ?string $path, string $mimeType): string {
-		if ($path !== null && $this->storage->file_exists($path)) {
+		if ($path !== null && $mimeType !== 'application/octet-stream') {
 			$this->mimeType[$storageId][$path] = $mimeType;
 		}