Skip to content

Commit

Permalink
Dark mode adjustments for popover
Browse files Browse the repository at this point in the history
Add new popover classes from @nextcloud/vue's Popover and PopoverMenu*
components. This fixes issues where the menu icons were not inverted.

Adjusted border for both the avatar popover menu and also actions
popover menu to make them easier to distinguish from the background.

Now using border color for the popover arrow to make it more visible
outside the border.

Signed-off-by: Vincent Petry <[email protected]>
  • Loading branch information
PVince81 committed Jan 20, 2021
1 parent 2c9345a commit 6e2c652
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions apps/accessibility/css/dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,12 @@ $color-border-dark: lighten($color-main-background, 14%);

.bubble,
.app-navigation-entry-menu,
.popovermenu {
.popovermenu,
.popover__menu {
li {
> button,
> a,
> .menuitem {
> .menuitem, > .popover__menuitem {
> img {
filter: invert(100%);
}
Expand All @@ -71,6 +72,22 @@ $color-border-dark: lighten($color-main-background, 14%);
border: 1px solid var(--color-border);
}

.popover[x-placement^='top'] .popover__arrow {
border-top-color: var(--color-border);
}
.popover[x-placement^='bottom'] .popover__arrow {
border-bottom-color: var(--color-border);
}
.popover[x-placement^='left'] .popover__arrow {
border-left-color: var(--color-border);
}
.popover[x-placement^='right'] .popover__arrow {
border-right-color: var(--color-border);
}
.popover .popover__inner {
border: 1px solid var(--color-border);
}

// Prevent slideshow icons from going dark
#slideshow {
[class^='icon-'], [class*=' icon-']{
Expand Down

0 comments on commit 6e2c652

Please sign in to comment.