Do not create remember me cookie

Signed-off-by: Julius Härtl <[email protected]>
nextcloud · Apr 21, 2020 · 6052f82 · 6052f82
1 parent 3c5914c
commit 6052f82
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/lib/private/Authentication/Login/FinishRememberedLoginCommand.php b/lib/private/Authentication/Login/FinishRememberedLoginCommand.php
@@ -26,18 +26,22 @@
 namespace OC\Authentication\Login;
 
 use OC\User\Session;
+use OCP\IConfig;
 
 class FinishRememberedLoginCommand extends ALoginCommand {
 
 	/** @var Session */
 	private $userSession;
+	/** @var IConfig */
+	private $config;
 
-	public function __construct(Session $userSession) {
+	public function __construct(Session $userSession, IConfig $config) {
 		$this->userSession = $userSession;
+		$this->config = $config;
 	}
 
 	public function process(LoginData $loginData): LoginResult {
-		if ($loginData->isRememberLogin()) {
+		if ($loginData->isRememberLogin() && $this->config->getSystemValue('auto_logout', false) === false) {
 			$this->userSession->createRememberMeToken($loginData->getUser());
 		}
 

diff --git a/tests/lib/Authentication/Login/FinishRememberedLoginCommandTest.php b/tests/lib/Authentication/Login/FinishRememberedLoginCommandTest.php
@@ -27,20 +27,25 @@
 
 use OC\Authentication\Login\FinishRememberedLoginCommand;
 use OC\User\Session;
+use OCP\IConfig;
 use PHPUnit\Framework\MockObject\MockObject;
 
 class FinishRememberedLoginCommandTest extends ALoginCommandTest {
 
 	/** @var Session|MockObject */
 	private $userSession;
+	/** @var IConfig|MockObject */
+	private $config;
 
 	protected function setUp(): void {
 		parent::setUp();
 
 		$this->userSession = $this->createMock(Session::class);
+		$this->config = $this->createMock(IConfig::class);
 
 		$this->cmd = new FinishRememberedLoginCommand(
-			$this->userSession
+			$this->userSession,
+			$this->config
 		);
 	}
 
@@ -57,6 +62,10 @@ public function testProcessNotRememberedLogin() {
 
 	public function testProcess() {
 		$data = $this->getLoggedInLoginData();
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('auto_logout', false)
+			->willReturn(false);
 		$this->userSession->expects($this->once())
 			->method('createRememberMeToken')
 			->with($this->user);
@@ -65,4 +74,18 @@ public function testProcess() {
 
 		$this->assertTrue($result->isSuccess());
 	}
+
+	public function testProcessNotRemeberedLoginWithAutologout() {
+		$data = $this->getLoggedInLoginData();
+		$this->config->expects($this->once())
+			->method('getSystemValue')
+			->with('auto_logout', false)
+			->willReturn(true);
+		$this->userSession->expects($this->never())
+			->method('createRememberMeToken');
+
+		$result = $this->cmd->process($data);
+
+		$this->assertTrue($result->isSuccess());
+	}
 }