Merge pull request #26084 from nextcloud/backport/26079/stable21

[stable21] Chunk the array of phone numbers
nextcloud · Mar 12, 2021 · 3ac6dc3 · 3ac6dc3
2 parents 6e2f7dd + 2d92f11
commit 3ac6dc3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/lib/private/Accounts/AccountManager.php b/lib/private/Accounts/AccountManager.php
@@ -229,19 +229,23 @@ public function getUser(IUser $user) {
 	}
 
 	public function searchUsers(string $property, array $values): array {
+		$chunks = array_chunk($values, 500);
 		$query = $this->connection->getQueryBuilder();
 		$query->select('*')
 			->from($this->dataTable)
 			->where($query->expr()->eq('name', $query->createNamedParameter($property)))
-			->andWhere($query->expr()->in('value', $query->createNamedParameter($values, IQueryBuilder::PARAM_STR_ARRAY)));
+			->andWhere($query->expr()->in('value', $query->createParameter('values')));
 
-		$result = $query->execute();
 		$matches = [];
+		foreach ($chunks as $chunk) {
+			$query->setParameter('values', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
+			$result = $query->execute();
 
-		while ($row = $result->fetch()) {
-			$matches[$row['value']] = $row['uid'];
+			while ($row = $result->fetch()) {
+				$matches[$row['value']] = $row['uid'];
+			}
+			$result->closeCursor();
 		}
-		$result->closeCursor();
 
 		return $matches;
 	}

diff --git a/tests/lib/Accounts/AccountsManagerTest.php → tests/lib/Accounts/AccountManagerTest.php b/tests/lib/Accounts/AccountsManagerTest.php → tests/lib/Accounts/AccountManagerTest.php
@@ -34,12 +34,12 @@
 use Test\TestCase;
 
 /**
- * Class AccountsManagerTest
+ * Class AccountManagerTest
  *
  * @group DB
  * @package Test\Accounts
  */
-class AccountsManagerTest extends TestCase {
+class AccountManagerTest extends TestCase {
 
 	/** @var  \OCP\IDBConnection */
 	private $connection;