fixup! feat(dav): dispatch out-of-office started and ended events

apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php

@@ -32,7 +32,6 @@
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\BackgroundJob\QueuedJob;
 use OCP\EventDispatcher\IEventDispatcher;
-use OCP\IUser;
 use OCP\IUserManager;
 use OCP\User\Events\OutOfOfficeEndedEvent;
 use OCP\User\Events\OutOfOfficeStartedEvent;
@@ -41,9 +40,6 @@ class OutOfOfficeEventDispatcherJob extends QueuedJob {
 	public const EVENT_START = 'start';
 	public const EVENT_END = 'end';
 
-	/** @var array<string, IUser> $users */
-	private array $userCache = [];
-
 	public function __construct(
 		ITimeFactory $time,
 		private AbsenceMapper $absenceMapper,
@@ -69,7 +65,7 @@ protected function run($argument) {
 		}
 
 		$userId = $absence->getUserId();
-		$user = $this->getUser($userId);
+		$user = $this->userManager->get($userId);
 		if ($user === null) {
 			$this->logger->error("Failed to dispatch out-of-office event: User $userId does not exist", [
 				'argument' => $argument,
@@ -88,18 +84,4 @@ protected function run($argument) {
 			]);
 		}
 	}
-
-	private function getUser(string $userId): ?IUser {
-		if (isset($this->userCache[$userId])) {
-			return $this->userCache[$userId];
-		}
-
-		$user = $this->userManager->get($userId);
-		if ($user === null) {
-			return null;
-		}
-
-		$this->userCache[$userId] = $user;
-		return $user;
-	}
 }

apps/dav/lib/Db/AbsenceMapper.php

@@ -56,7 +56,7 @@ public function findById(int $id): Absence {
 		try {
 			return $this->findEntity($qb);
 		} catch (MultipleObjectsReturnedException $e) {
-			// Won't happen as there is a unique index on user_id
+			// Won't happen as id is the primary key
 			throw new \RuntimeException(
 				'The impossible has happened! The query returned multiple absence settings for one user.',
 				0,