Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perf(dashboard): implement widget item api v2" #667

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 30, 2023

This reverts commit 52feace.

I tested this locally and the dashboard widgets works like it did before (builtin viewer etc.).

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2024

Status @st3iny ?
This works too #702 🤔

@susnux
Copy link
Contributor

susnux commented Mar 9, 2024

Can we somehow add a selector to the widget item API?
Meaning that it renders the widget with a class or ID assigned so we could hook into that.

So we could just use a very small script to add viewer support and still benefit from not needed to provide a full dashboard bundle

@skjnldsv
Copy link
Member

@ChristophWurst @st3iny we're entering RC1, if this revert is important, it needs to get in asap! 👍

Otherwise, either close or change the milestone 🙏

@st3iny st3iny force-pushed the revert/644 branch 2 times, most recently from 2bc30b3 to 014e258 Compare March 30, 2024 07:09
@st3iny
Copy link
Member Author

st3iny commented Mar 30, 2024

I rebased, resolved conflicts and tested again. I also fixed CI to finally make it green.

@st3iny
Copy link
Member Author

st3iny commented Mar 30, 2024

@skjnldsv Your call regarding the merge. I'm not sure given that we had rc.1 already.

@Pytal
Copy link
Member

Pytal commented Apr 1, 2024

master is now 30, moving to 30

@Pytal Pytal modified the milestones: Nextcloud 29, Nextcloud 30 Apr 1, 2024
This reverts commit 52feace.

Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal merged commit 75823cf into master Apr 1, 2024
23 of 25 checks passed
@Pytal Pytal deleted the revert/644 branch April 1, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants