Add note to development setup docs about committing built files #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect, thanks a lot @ChristophWurst – that is a sentence we can also use in other apps where this is a requirement. :) |
gary-kim
approved these changes
Dec 10, 2019
gary-kim
reviewed
Dec 10, 2019
jancborchardt
force-pushed
the
design/development-note
branch
from
90086a1
to
6f49ab1
Compare
|
@gary-kim good point – added that. :) Ready to 🚢! |
|
DCO says no. Mind squashing? |
Co-Authored-By: Christoph Wurst <[email protected]> Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
force-pushed
the
design/development-note
branch
from
6f49ab1
to
8992a03
Compare
|
Squashed into a signed commit, should run through now :) |
ChristophWurst
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this cause I was unsure whether the built files have to be committed or not. So here’s a note for clarification. :)
As per your comment @ChristophWurst #156 (review)
Does this sound good?