feat: Keep unchanged indices and foreign keys instead of recreating #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
feat/keep-unchanged-indices-on-update
branch
from
734304e
to
666dffe
Compare
12 tasks
|
I should’ve duplicate the methods instead of renaming them, not sure how I missed that they were also used elsewhere -_- |
dartcafe
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Without checking this change by detail ATM. I had a call with @AndyScherzinger yesterday. I will start a new PR to be able to get a quick solution first, which can be pushedf to the appstore and with the latest fixes.
I will link it after the first commit and decribe what my plan is. I will link it here and inside the original issue.
Would be happy to get your review and maybe some tests are possible.
|
Closing this since indices are not dropped by the repair step anymore in master 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As an alternative to switching to the standard way of handling schemas and indices, this PR avoid recreating already correct indices and foreign keys.
On foreign keys I’m less sure because I fail to see why they were recreated to start with, given that they are only removed on tables from
TableSchema::FK_CHILD_TABLES, and I do not think the name of the parent table can ever change?