-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: space in token causes 404 on logout #3677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange. Never saw that. How can a space get added to the cookie name, which is returned from the delete function.
I think it better gets trimmed inside the function.
Signed-off-by: Hamza Mahjoubi <[email protected]>
09b202d
to
f49c4f0
Compare
I also couldn't figure out why it's happening |
🤷 |
Signed-off-by: dartcafe <[email protected]>
I noticed after loging out from a public share sometime a space character gets added to the token -> route which causes a 404
I'm still not sure why it happens and it doesn't look deterministic, I'm still investigating
Notice the extra space in the following screenshots