-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement file selector #502
Conversation
Signed-off-by: Corentin Mors <[email protected]>
I wanted to use a Set to keep track of selected files. It's very performant for such usage. But VueJS does not support Set and Map collections as reactive. Let me know if you have ideas on how we can improve this. I'm really not into using an array here tbh. |
Signed-off-by: Corentin Mors <[email protected]>
@skjnldsv done with the new changes @jancborchardt I'd like advices on the design part |
@Mikescops |
Cool! Here’s some design feedback:
|
@jancborchardt I will answer a few remarks first. Yes the sidebar open when you click on files (I know it may not be wanted but I was looking for a simple way to open the sidebar and it just felt like the preview sidebar on Windows or Linux that is opened when you click on an image) I first displayed the select bar at the bottom because if it's at the top it is hiding the navigation bar in the folders, so I don't know how you want to handle that. |
@jakobroehrl yes goal is to later add some action buttons, but one thing at the time. |
Hm, since our focus is Photos and not "a photos view of files", clicking on an image should always open the image. We could discuss that it should also always open the sidebar, but I think that having the sidebar open without also having the viewer open is not really necessary.
It’s totally fine to replace the navigation bar as well, kind of like Android does. Full focus on the task at hand, which then is selection. |
Implemented |
Add file selection to the grid and open sidebar when selecting a new file.