Handle node deletion event

[skjnldsv]

To remove files from album when they are deleted.

Signed-off-by: Louis Chemineau [email protected]

From #1161
Fix #1226

[artonge]

Thanks.

Unrelated, but damn you gotta love how powerful git is!

[artonge]

Note that you'll still have to remove broken files in the database

[skjnldsv]

Note that you'll still have to remove broken files in the database

Broken files?
Broken albums you mean?
We could also add a check when we get the children and remove the missing references.
While this could be expensive, this would only be a failsafe as the event would already be there

[skjnldsv]

Also, if the node gets put to trash, does it fire the NodeDeletedEvent ?
Because the fileId would still exists, no?

[artonge]

Also, if the node gets put to trash, does it fire the NodeDeletedEvent ?
Because the fileId would still exists, no?

I thought that NodeDeletedEvent was for when the file is put in the trashbin, confused

[skjnldsv]

I thought that NodeDeletedEvent was for when the file is put in the trashbin, confused

Well, what if you disabled the trashbin? :p

[skjnldsv]

Added some check in the propfind where it was throwing before

[artonge]

@skjnldsv for folders, the NodeDeletedEvent is only triggered for the folders, and not media inside the folder. Are you aware of another event that will be triggered for every files, or should we walk the folder manually ?

[skjnldsv]

@skjnldsv for folders, the NodeDeletedEvent is only triggered for the folders, and not media inside the folder. Are you aware of another event that will be triggered for every files, or should we walk the folder manually ?

Ah!
There is the old hooks iirc. e.g
https://github.com/nextcloud/server/blob/ac2bc2384efe3c15ff987b87a7432bc60d545c67/lib/private/Files/Node/HookConnector.php#L149-L157