-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix service-worker #1204
Merged
Merged
fix service-worker #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
added
bug
Something isn't working
3. to review
Waiting for reviews
performances
Performances issues and optimisations
labels
Sep 3, 2022
szaimen
commented
Sep 3, 2022
szaimen
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Sep 3, 2022
szaimen
force-pushed
the
fix/noid/service-worker
branch
from
September 4, 2022 00:32
ff0ffc0
to
45f0a60
Compare
szaimen
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Sep 4, 2022
artonge
approved these changes
Sep 6, 2022
CarlSchwan
approved these changes
Sep 6, 2022
skjnldsv
requested changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for #1206
/rebase |
nextcloud-command
force-pushed
the
fix/noid/service-worker
branch
from
September 6, 2022 08:44
45f0a60
to
34a35a7
Compare
/compile amend / |
skjnldsv
approved these changes
Sep 6, 2022
Signed-off-by: szaimen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/noid/service-worker
branch
from
September 6, 2022 08:52
34a35a7
to
573b132
Compare
/backport to stable24 |
backportbot-nextcloud
bot
added
the
backport-request
Pending backport by the backport-bot
label
Sep 7, 2022
/backport to stable23 |
This was referenced Sep 7, 2022
backportbot-nextcloud
bot
removed
the
backport-request
Pending backport by the backport-bot
label
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
performances
Performances issues and optimisations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via https://github.com/search?q=org%3Anextcloud+noRewrite&type=code
Disclaimer: I wasn't able to test this but I think it should work.
See also nextcloud/bookmarks#1078 (comment)
Signed-off-by: szaimen [email protected]