Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service-worker #1204

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix service-worker #1204

merged 1 commit into from
Sep 6, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 3, 2022

Found via https://github.com/search?q=org%3Anextcloud+noRewrite&type=code

Disclaimer: I wasn't able to test this but I think it should work.

See also nextcloud/bookmarks#1078 (comment)

Signed-off-by: szaimen [email protected]

@szaimen szaimen added bug Something isn't working 3. to review Waiting for reviews performances Performances issues and optimisations labels Sep 3, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 3, 2022
src/Photos.vue Outdated Show resolved Hide resolved
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 3, 2022
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 4, 2022
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #1206

@skjnldsv
Copy link
Member

skjnldsv commented Sep 6, 2022

/rebase

@skjnldsv
Copy link
Member

skjnldsv commented Sep 6, 2022

/compile amend /

Signed-off-by: szaimen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv merged commit 4586bca into master Sep 6, 2022
@skjnldsv skjnldsv deleted the fix/noid/service-worker branch September 6, 2022 08:57
@szaimen
Copy link
Contributor Author

szaimen commented Sep 7, 2022

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Sep 7, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 7, 2022

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working performances Performances issues and optimisations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants