Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement upload in Folder #1194

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Implement upload in Folder #1194

merged 2 commits into from
Sep 1, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 31, 2022 •
edited
Loading

Peek.01-09-2022.12-20.mp4

@skjnldsv skjnldsv self-assigned this Aug 31, 2022
@skjnldsv skjnldsv added the 2. developing Work in progress label Aug 31, 2022
@skjnldsv skjnldsv force-pushed the feat/upload branch 2 times, most recently from 44efb9b to 3a3e725 Compare September 1, 2022 10:30
@skjnldsv skjnldsv marked this pull request as ready for review September 1, 2022 10:30
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 1, 2022
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 1, 2022

@artonge ready for a first review! If you have any questions :)
Currently only file upload in folders.
I did not use the default folder as if you're displaying the root and upload a file, you would expect this to be in the Root folder I think

@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Sep 1, 2022
skjnldsv
skjnldsv commented Sep 1, 2022
View reviewed changes
src/views/Folders.vue Outdated Show resolved Hide resolved
@blizzz blizzz mentioned this pull request Sep 1, 2022
Merged
@skjnldsv skjnldsv force-pushed the feat/upload branch 2 times, most recently from 600dae1 to 3a3b7bd Compare September 1, 2022 12:56
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 1, 2022

/rebase

@skjnldsv skjnldsv force-pushed the feat/upload branch 3 times, most recently from ea04635 to 9843b46 Compare September 1, 2022 14:16
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv
Implement upload in Folder
3c0ca63 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 1, 2022

/compile amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2022
@skjnldsv skjnldsv merged commit 4951d07 into master Sep 1, 2022
@skjnldsv skjnldsv deleted the feat/upload branch September 1, 2022 16:34
@skjnldsv skjnldsv mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@marcelklehr marcelklehr Awaiting requested review from marcelklehr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @marcelklehr @artonge