-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework tags view #1191
Rework tags view #1191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow so cool! Looks really nice :) Some details:
- The title in the navigation would be better as "Tags" instead of "Tagged photos"?
- The popular tags are not sorted by ones with most photos yet
- Some of the previews seem to have square corners instead of rounded, possibly cause they are not filling the container, not sure?
- The titles "Popular tags" and "All tags" could be moved a bit to the right to left-align with the leftmost image preview (not the hover effect)
- Between the "Popular tags" section and the "All tags" heading, a bit of whitespace would be nice (similar to how we do it in the "All media" view for the month headings)
- The albums look quite large, or is that just me? Maybe it’s fine. :) Is the size fixed, or calculated based on screen size? (cc @artonge as I guess it just uses the album size and we should make sure the sizing is the same :)
Otherwise all really really nice!
Not the same component, but I assume @marcelklehr used the same size. |
Woah looks super cool! :) Agree with everything, especially the sizing of the photos, plus possibly:
|
Tag cover size is the same as album covers, but will get smaller on mobile.
Done. |
8abcb2b
to
efdbc4f
Compare
New screens: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, good to go design-wise! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Doesn't it miss some padding in the TagContent. Is it en purpose ?
I didn't add any padding after reworking, yeah. The timeline view for example indeed has padding. Do we want padding on the photos container here @nimishavijay @jancborchardt? |
…anges Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Louis <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
21e0f76
to
8b4bb4f
Compare
/compile amend /js |
8b4bb4f
to
cf75d42
Compare
Right, yes would be good if it has the same padding as on the timeline view. :) |
cf75d42
to
b08047c
Compare
/compile amend /js |
Signed-off-by: Marcel Klehr <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
b08047c
to
1d5ef26
Compare
based on #1162
Screencast: https://cloud.marcelklehr.de/s/sxEm6Nd65xT8GZW/download/Peek%202022-08-31%2012-22.gif