Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not taking into account the .noimage flag #75

Closed
tillwf opened this issue Dec 26, 2019 · 18 comments · Fixed by #159
Closed

Not taking into account the .noimage flag #75

tillwf opened this issue Dec 26, 2019 · 18 comments · Fixed by #159
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working medium Medium priority

Comments

@tillwf
Copy link

tillwf commented Dec 26, 2019

Folders with the file .noimage are still viewable.

@Mikescops
Copy link
Member

Exact, I could reproduce that one too.

@Mikescops Mikescops added the bug Something isn't working label Dec 26, 2019
@skjnldsv
Copy link
Member

Ah right! :)
@rullzer can we exclude this from the albums?

@skjnldsv skjnldsv added the 0. Needs triage Pending approval or rejection. This issue is pending approval. label Dec 26, 2019
@rullzer
Copy link
Member

rullzer commented Jan 18, 2020

Sure.

@rullzer rullzer self-assigned this Jan 18, 2020
@PriceChild
Copy link

PriceChild commented Jan 19, 2020

There's precedent for looking for two files:

  • Ignore folders containing a ".nomedia" or ".noimage" file

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of medium Medium priority and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 19, 2020
@skjnldsv skjnldsv added this to the 1.1.0 milestone Jan 19, 2020
@SimpleRealDT

This comment has been minimized.

@archont00
Copy link

Yep. I have a music folder with really a lot of sub-folders, many having an Album Cover image. Showing these images in Photos not a way to go.

@skjnldsv skjnldsv modified the milestones: 1.1.0, 1.0.1 Jan 22, 2020
rullzer added a commit that referenced this issue Jan 27, 2020
Fixes #75

When a folder has a .noimage or .nomedia node. Just don't show the
folder in the album overview. Ignore it and do not traverse it.

Signed-off-by: Roeland Jago Douma <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Jan 27, 2020
Fixes #75

When a folder has a .noimage or .nomedia node. Just don't show the
folder in the album overview. Ignore it and do not traverse it.

Signed-off-by: Roeland Jago Douma <[email protected]>
@slgray
Copy link

slgray commented Mar 5, 2020

My Nextcloud Server version is 18.0.1 and the Photos App version is 1.0.0, the problem still exist. Do I need to upgrade the Photos App?

@skjnldsv
Copy link
Member

skjnldsv commented Mar 5, 2020

@slgray which view are we talking about here?

@slgray
Copy link

slgray commented Mar 5, 2020

@slgray which view are we talking about here?

Hi @skjnldsv, it is Your photos
2020-03-05_22-18

@skjnldsv
Copy link
Member

skjnldsv commented Mar 5, 2020

Ah, it is not taken into account there though 🤔
Though I guess can be fixed with #141

@slgray
Copy link

slgray commented Mar 6, 2020

Got it, thanks.

@muety
Copy link

muety commented Mar 10, 2020

I'm running Nextcloud 18.0.1 with Photos 1.0.0, but the bug still occurs. Can somebody help me getting this fixed through an update or so?

@lbdroid
Copy link

lbdroid commented Mar 12, 2020

Ah, it is not taken into account there though
Though I guess can be fixed with #141

That wouldn't fix it, that would only obscure it. It should still be possible to add a .nomedia file into some subdirectory of the designated "photos" tree, for instance, to block off a thumbnails directory.

@skjnldsv
Copy link
Member

-> #234

@steve4835
Copy link

Any update on this? It is still an issue in Nextcloud 22

@marcelklehr
Copy link
Member

@steve4835 This is fixed in Nextcloud 24

@q2apro
Copy link

q2apro commented Jan 9, 2024

Bug not resolved.

I added .noimage to several folders, but the same images are still showing up in the gallery.

Please make sure that .noimage means that the folder and all its subfolders are not indexed by the Nextcloud photo app.

@marcelklehr
Copy link
Member

Hi @q2apro
this issue was closed 4 years ago, it's likely this is a regression. As such, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working medium Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.