Merge pull request #2661 from nextcloud/backport/2658/stable30

[stable30] feat: Check upload directory share state
nextcloud · Sep 25, 2024 · f1da47a · f1da47a
2 parents e9390ae + 15566c9
commit f1da47a
Show file tree

Hide file tree

Showing 12 changed files with 56 additions and 28 deletions.
diff --git a/js/photos-main.js b/js/photos-main.js
diff --git a/js/photos-main.js.map b/js/photos-main.js.map
diff --git a/...e_modules_vue-material-design-icons_FolderMultipleImage_vue-src_views_AlbumContent_vue.js b/...e_modules_vue-material-design-icons_FolderMultipleImage_vue-src_views_AlbumContent_vue.js
diff --git a/...dules_vue-material-design-icons_FolderMultipleImage_vue-src_views_AlbumContent_vue.js.map b/...dules_vue-material-design-icons_FolderMultipleImage_vue-src_views_AlbumContent_vue.js.map
diff --git a/js/photos-public.js b/js/photos-public.js
diff --git a/js/photos-public.js.map b/js/photos-public.js.map
diff --git a/js/photos-src_components_Collection_CollectionContent_vue-src_components_PhotosPicker_vue.js b/js/photos-src_components_Collection_CollectionContent_vue-src_components_PhotosPicker_vue.js
diff --git a/...os-src_components_Collection_CollectionContent_vue-src_components_PhotosPicker_vue.js.map b/...os-src_components_Collection_CollectionContent_vue-src_components_PhotosPicker_vue.js.map
diff --git a/js/photos-src_views_SharedAlbumContent_vue.js b/js/photos-src_views_SharedAlbumContent_vue.js
diff --git a/js/photos-src_views_SharedAlbumContent_vue.js.map b/js/photos-src_views_SharedAlbumContent_vue.js.map
diff --git a/lib/Sabre/Album/AlbumRoot.php b/lib/Sabre/Album/AlbumRoot.php
@@ -14,6 +14,7 @@
 use OCA\Photos\Album\AlbumWithFiles;
 use OCA\Photos\Service\UserConfigService;
 use OCP\Files\Folder;
+use OCP\Files\InvalidDirectoryException;
 use OCP\Files\IRootFolder;
 use OCP\Files\NotFoundException;
 use Sabre\DAV\Exception\Conflict;
@@ -91,6 +92,10 @@ public function createFile($name, $data = null) {
 				throw new Conflict('The destination exists and is not a folder');
 			}
 
+			if ($photosFolder->isShared()) {
+				throw new InvalidDirectoryException('The destination is a received share');
+			}
+
 			// Check for conflict and rename the file accordingly
 			$newName = \basename(\OC_Helper::buildNotExistingFileName($photosLocation, $name));
 

diff --git a/src/components/PhotosPicker.vue b/src/components/PhotosPicker.vue
@@ -43,18 +43,25 @@
 
 		<!-- The actions on the bottom -->
 		<template #actions>
-			<UploadPicker :accept="allowedMimes"
-				:context="uploadContext"
-				:destination="photosLocationFolder"
-				:multiple="true"
-				@uploaded="refreshFiles" />
-			<NcButton type="primary" :disabled="loading || selectedFileIds.length === 0" @click="emitPickedEvent">
-				<template #icon>
-					<ImagePlus v-if="!loading" />
-					<NcLoadingIcon v-if="loading" />
-				</template>
-				{{ t('photos', 'Add to {destination}', { destination }) }}
-			</NcButton>
+			<div class="photos-picker__actions">
+				<div class="photos-picker__actions__buttons">
+					<UploadPicker :accept="allowedMimes"
+						:context="uploadContext"
+						:destination="photosLocationFolder"
+						:multiple="true"
+						@uploaded="refreshFiles" />
+					<NcButton type="primary" :disabled="loading || selectedFileIds.length === 0" @click="emitPickedEvent">
+						<template #icon>
+							<ImagePlus v-if="!loading" />
+							<NcLoadingIcon v-if="loading" />
+						</template>
+						{{ t('photos', 'Add to {destination}', { destination }) }}
+					</NcButton>
+				</div>
+				<NcNoteCard v-if="photosLocationFolder.attributes['owner-id'] !== currentUser" type="warning">
+					{{ t('photos', 'The destination folder is owned by {owner}', { owner: photosLocationFolder.attributes['owner-id'] }) }}
+				</NcNoteCard>
+			</div>
 		</template>
 
 		<FilesListViewer class="photos-picker__file-list"
@@ -89,11 +96,12 @@
 
 <script>
 import { UploadPicker } from '@nextcloud/upload'
-import { NcButton, NcDialog, NcLoadingIcon, NcSelect, useIsMobile } from '@nextcloud/vue'
+import { NcButton, NcDialog, NcLoadingIcon, NcSelect, NcNoteCard, useIsMobile } from '@nextcloud/vue'
 import { defineComponent } from 'vue'
 import { mapGetters } from 'vuex'
 
 import moment from '@nextcloud/moment'
+import { getCurrentUser } from '@nextcloud/auth'
 
 import ImagePlus from 'vue-material-design-icons/ImagePlus.vue'
 
@@ -116,6 +124,7 @@ export default defineComponent({
 		NcDialog,
 		NcLoadingIcon,
 		NcSelect,
+		NcNoteCard,
 		UploadPicker,
 	},
 
@@ -176,6 +185,7 @@ export default defineComponent({
 			uploadContext: {
 				route: 'albumpicker',
 			},
+			currentUser: getCurrentUser(),
 		}
 	},
 
@@ -280,5 +290,18 @@ export default defineComponent({
 			justify-content: center;
 		}
 	}
+
+	&__actions {
+		display: flex;
+		flex-direction: column;
+		flex-grow: 1;
+
+		&__buttons {
+			display: flex;
+			align-items: center;
+			justify-content: end;
+			gap: 16px;
+		}
+	}
 }
 </style>