Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite height values #528

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Do not overwrite height values #528

merged 2 commits into from
Jan 7, 2020

Conversation

juliusknorr
Copy link
Member

Signed-off-by: Julius Härtl [email protected]

@juliusknorr
Do not overwrite height values
406bc74 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr mentioned this pull request Dec 31, 2019
Merged
jancborchardt
jancborchardt approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the missing triangle issue for me! 👍

@juliusknorr juliusknorr mentioned this pull request Jan 5, 2020
Closed
@rullzer rullzer mentioned this pull request Jan 5, 2020
Merged
1 task
@wiswedel
Copy link

wiswedel commented Jan 6, 2020

fixes nextcloud/server#18647

@nickvergessen
Copy link
Member

Please dont merge until i reviewed

@nickvergessen
Add missing border
c75a3eb 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen merged commit 1f6e00d into master Jan 7, 2020
@nickvergessen nickvergessen deleted the bugfix/16057 branch January 7, 2020 08:39
@ChristophWurst ChristophWurst mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiswedel wiswedel wiswedel approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @wiswedel @nickvergessen @jancborchardt