-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: replace Terser plugin with Esbuild #1998
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Antreesy
commented
Aug 6, 2024
State | Before | After | Diff |
---|---|---|---|
Size | 26.7 Mb | 31.8 Mb | 🔼 +19% |
Time | 50 943 ms | 14 765 ms | 🔽 -71% |
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
3. to review
dependencies
Pull requests that update a dependency file
labels
Aug 6, 2024
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
To make it faster, we can also get rid of Babel for transpiling. Or fully migrate to Vite. Should be simple for a small app. |
And extract CSS |
Feel free to take over, while we are still in beta phase 😉 I tried esbuild as it's less painful step |
Fine by me? |
ShGKme
approved these changes
Aug 12, 2024
As it was introduced only in Nc30, closing in favor of #2002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.