Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace Terser plugin with Esbuild #1998

Closed
wants to merge 3 commits into from

Conversation

Antreesy
Copy link
Collaborator

@Antreesy Antreesy commented Aug 6, 2024

State Before After Diff
Size 26.7 Mb 31.8 Mb 🔼 +19%
Time 50 943 ms 14 765 ms 🔽 -71%

@Antreesy Antreesy added 3. to review dependencies Pull requests that update a dependency file labels Aug 6, 2024
@Antreesy Antreesy added this to the Nextcloud 30 milestone Aug 6, 2024
@Antreesy Antreesy requested a review from ShGKme August 6, 2024 07:55
@Antreesy Antreesy self-assigned this Aug 6, 2024
@Antreesy
Copy link
Collaborator Author

Antreesy commented Aug 6, 2024

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy marked this pull request as ready for review August 6, 2024 08:30
@ShGKme
Copy link
Contributor

ShGKme commented Aug 6, 2024

To make it faster, we can also get rid of Babel for transpiling. Or fully migrate to Vite. Should be simple for a small app.

@ShGKme
Copy link
Contributor

ShGKme commented Aug 6, 2024

And extract CSS

@Antreesy
Copy link
Collaborator Author

Antreesy commented Aug 6, 2024

Or fully migrate to Vite

Feel free to take over, while we are still in beta phase 😉

I tried esbuild as it's less painful step

@nickvergessen
Copy link
Member

Fine by me?

@Antreesy
Copy link
Collaborator Author

As it was introduced only in Nc30, closing in favor of #2002

@Antreesy Antreesy closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants