Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #1370

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Fix unit tests #1370

merged 2 commits into from
Nov 16, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 16, 2022 •
edited
Loading

Follow up to #1266

@nickvergessen
Fix unit tests
6a98da7 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Nov 16, 2022
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10391 was 9500 (+9.37%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
Fix psalm
512df27 
Signed-off-by: Joas Schilling <[email protected]>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 10391 was 9500 (+9.37%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 4ea881f into master Nov 16, 2022
@nickvergessen nickvergessen deleted the followup/1266/fix-tests branch November 16, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
1 participant
@nickvergessen