fix/shared notes #1320
Merged
fix/shared notes #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code change looks ok. Except the linting issue at https://github.com/nextcloud/notes/pull/1320/files#diff-7f7d9bb77038513c05d8a832f52c8b4ef5a00af9373c6b2fdaaf24b5b7d907d3R33
juliusknorr
force-pushed
the
fix/shared-notes
branch
from
aabf14b
to
820a315
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
…set manually Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/shared-notes
branch
from
820a315
to
d8e6271
Compare
luka-nextcloud
approved these changes
Jul 15, 2024
|
/backport to stable4.10 |
|
@juliushaertl It's working, but I need a small workaround and I'm not sure, if this expected. If I share my folder from my main account to my android account, the shared folder is also named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current backend logic to get or create a notes folder is not ideal as we cannot easily determine if a folder exists because a user has created and set is as notes folder before or if it was manually picked as a notes folder.
To avoid issues with the wrong incoming shared folder being taken as notes folder automatically this PR refactors the logic so that we now no longer store the notes folder in the config with the default value, until it was actually created. That way we know as soon as the config value is set, we no longer need to check for incoming shares on the folder.
Fix #1266