Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: removed #1004

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Sidebar: removed #1004

merged 4 commits into from
Nov 7, 2023

Conversation

theatischbein
Copy link
Contributor

Following #967 I removed the sidebar, because the only remaining function category can also be accessed via the app navigation. Also the sidebar isn't accessable in the richtext editor anyways.

@juliusknorr
Copy link
Member

Glad to see so many awesome contributions @jonnytischbein I'll probably only get to review at the end of this week, but I try to go through them as soon as possible.

@juliusknorr
Copy link
Member

So currently the app navigation actions menu does not offer a way to set the category just to navigate to it, which is something we'd need to address differently if we drop the sidebar. (#970)

We don't have any outline yet how that could look like, so if you would have any suggestion for that UI wise we should discuss that first. Otherwise maybe @nimishavijay or @jancborchardt have more input for how the category could be selected in the navigation.

@theatischbein
Copy link
Contributor Author

theatischbein commented Apr 15, 2023

So currently the app navigation actions menu does not offer a way to set the category just to navigate to it, which is something we'd need to address differently if we drop the sidebar. (#970)

My suggestion would be to move the Category dropdown menu from the sidebar to ... context menu from a note.
Maybe in a small modal like adding a new Category in #1002 or the contact Add Group

I can try to implement that in a bit

@theatischbein
Copy link
Contributor Author

I am not fully content with this, but didn't know how to trigger a popper div from an action menu.

What do you think ?

image

@theatischbein
Copy link
Contributor Author

theatischbein commented Apr 16, 2023

I did another mockup, but still keep to figure out how to adjust the appearance of the menu item:

Screenshot from 2023-04-16 17-16-27

ezgif com-video-to-gif

<NcActions :force-menu="true" :force-title="true" :menu-title="actionCategoryText">
    <template #icon>
        <FolderIcon :size="20" />
    </template>				
   <NcSelect id="category"
	:value="category"
	:options="categories"
	:placeholder="t('notes', 'Uncategorized')"
	:disabled="loading.category"
	:class="['category-select', {'icon-loading-small': loading.category}]"
	:show-no-results="false"
	:taggable="true"
        :preserve-search="true"
	:title="t('notes', 'Set category')"
	@input="onSaveCategory"
        @close="onFinishEditCategory"
        @search-change="onEditCategory"
    />
</NcActions>
``

@juliusknorr
Copy link
Member

Took the liberty to rebase this PR :)

Signed-off-by: Jonathan Pagel <[email protected]>
@juliusknorr
Copy link
Member

I also further pushed a commit to include #1104 and making use of NcActionInput multiselect for switching the category.

The overflow is not the nicest there yet, but this is something that should probably be fixed upstream.
Uploading Screenshot 2023-11-07 at 14.53.42.png…

@juliusknorr juliusknorr merged commit e3d6e56 into nextcloud:main Nov 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants