Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override showTrailingButton from an NcAction #4010

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Allow to override showTrailingButton from an NcAction #4010

merged 1 commit into from
Apr 27, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 26, 2023 •
edited
Loading

This would allow to not show the eye icon on sharing password field.

New NcActionInput examples:

Screenshot from 2023-04-27 14-37-29

Use case example in sharing (nextcloud/server#37954):

Before After
Screenshot from 2023-04-27 15-30-09 Screenshot from 2023-04-27 14-59-48
Screenshot from 2023-04-27 14-49-40 Screenshot from 2023-04-27 14-59-52
Screenshot from 2023-04-27 14-49-47 -

@artonge artonge self-assigned this Apr 26, 2023
@artonge artonge added 2. developing Work in progress feature: actions Related to the actions components labels Apr 26, 2023
@artonge artonge added this to the 7.11.0 milestone Apr 26, 2023
@artonge artonge added the feature: input-field Covering the InputField, TextField, ... label Apr 26, 2023
@artonge artonge force-pushed the artonge/feat/override_showTrailingButton_from_NcAction branch from 076a1f6 to 69e8a67 Compare April 27, 2023 12:47
@artonge artonge mentioned this pull request Apr 27, 2023
Merged
2 tasks
@artonge artonge marked this pull request as ready for review April 27, 2023 13:37
@artonge artonge requested review from a team, skjnldsv, Pytal and szaimen and removed request for a team April 27, 2023 13:37
szaimen
szaimen approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the docs and seems to work

@artonge artonge merged commit f0b64da into master Apr 27, 2023
@artonge artonge deleted the artonge/feat/override_showTrailingButton_from_NcAction branch April 27, 2023 14:35
@artonge artonge mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@artonge artonge

Labels
2. developing Work in progress feature: actions Related to the actions components feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
7.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @skjnldsv @szaimen