Use common webpack config #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
feat/noid/common-webpack
branch
from
25605c4
to
347eaa3
Compare
skjnldsv
approved these changes
Jan 10, 2023
|
Don't merge this yet, |
skjnldsv
reviewed
Jan 10, 2023
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
feat/noid/common-webpack
branch
from
347eaa3
to
b5a5605
Compare
Fixed it, |
raimund-schluessler
requested review from
marcoambrosini,
GretaD,
juliusknorr,
Pytal and
CarlSchwan
GretaD
approved these changes
Jan 10, 2023
|
Awesome @raimund-schluessler 🤗 |
skjnldsv
added
enhancement
Merged
skjnldsv
reviewed
Jan 11, 2023
| webpackConfig.output = { | ||
| path: path.resolve(__dirname, './dist'), | ||
| publicPath: '/dist/', | ||
| filename: `[name].${libraryTarget}.js`, |
There was a problem hiding this comment.
this is a breaking change @raimund-schluessler please revert
There was a problem hiding this comment.
Sorry, I must have mixed it up with the if (libraryTarget !== 'umd') section.
skjnldsv
added a commit
that referenced
this pull request
Jan 11, 2023
see #3633 Signed-off-by: John Molakvoæ <[email protected]>
| }, | ||
| umdNamedDefine: true, | ||
| webpackConfig.entry = { | ||
| index: path.join(__dirname, 'src', 'index.js'), |
There was a problem hiding this comment.
@skjnldsv Comparing https://github.com/nextcloud/nextcloud-vue/blob/master/webpack.config.js with https://github.com/nextcloud/nextcloud-vue/blob/v7.3.0/webpack.config.js I think this also needs to go into the umd section here:
https://github.com/nextcloud/nextcloud-vue/blob/e5999882e2ae4fe22b2c72e3671ef509e1e8a36e/webpack.config.js#L159-L161
skjnldsv
added a commit
that referenced
this pull request
Jan 11, 2023
see #3633 Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
added a commit
that referenced
this pull request
Jan 11, 2023
see #3633 Signed-off-by: John Molakvoæ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the common webpack config.
However,
npm run styleguideis broken (see #3634), which needs to be fixed before we can decide how to proceed here.