Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert webpack output file name #3644

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jan 11, 2023
@skjnldsv skjnldsv added this to the 7.4.0 milestone Jan 11, 2023
@skjnldsv skjnldsv requested review from raimund-schluessler and a team January 11, 2023 10:00
@skjnldsv skjnldsv self-assigned this Jan 11, 2023
@skjnldsv skjnldsv requested review from artonge, Pytal and szaimen and removed request for a team January 11, 2023 10:00
This was referenced Jan 11, 2023
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the fix(webpack)-revert-output-file-name branch from 7bd1d51 to 643ccc6 Compare January 11, 2023 12:21
@skjnldsv

This comment was marked as resolved.

@raimund-schluessler

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 11, 2023
@skjnldsv

This comment was marked as resolved.

see #3633

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv force-pushed the fix(webpack)-revert-output-file-name branch from 643ccc6 to cffec25 Compare January 11, 2023 12:38
@skjnldsv
Copy link
Contributor Author

Fixed, both 7.3 and this now output 4 directories and 166 files.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 11, 2023
@skjnldsv skjnldsv merged commit f7266d8 into master Jan 11, 2023
@skjnldsv skjnldsv deleted the fix(webpack)-revert-output-file-name branch January 11, 2023 12:41
@raimund-schluessler
Copy link
Contributor

@skjnldsv Thanks for taking care and cleaning up behind me 🙈 😆

@skjnldsv skjnldsv mentioned this pull request Jan 11, 2023
@skjnldsv
Copy link
Contributor Author

@skjnldsv Thanks for taking care and cleaning up behind me see_no_evil laughing

Well, we're all here for each others 🤗
Thanks for pushing forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants