Add aria-label to single action button #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
added
bug
raimund-schluessler
requested review from
nickvergessen,
JuliaKirschenheuter,
skjnldsv and
marcoambrosini
marcoambrosini
approved these changes
Aug 9, 2022
skjnldsv
approved these changes
Aug 9, 2022
|
backport? |
No, we didn't backport #2911 either, which introduced the problem. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default
aria-labelwith the value of the tooltip to the single action button, fixing theYou need to fill either the text or the ariaLabel props in the button component.warning that currently occurs in the docs for single actions if theActionButtonhas noaria-labelset. Follow-up of #2911.