Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require nextcloud 20 for new development #794

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Require nextcloud 20 for new development #794

merged 4 commits into from
Sep 25, 2020

Conversation

SMillerDev
Copy link
Contributor

No description provided.

@SMillerDev SMillerDev force-pushed the require_20 branch 5 times, most recently from ac0622b to ab59d01 Compare September 20, 2020 20:48
@Grotax
adjust travis to stable20
f8f810d 
Signed-off-by: Benjamin Brahmer <[email protected]>
@SMillerDev
Copy link
Contributor Author

Should we be using mariadb as server type? Or would this query just never have worked for people who use MariaDB?

@Grotax
Copy link
Member

Grotax commented Sep 23, 2020

I'm a bit confused too...
Didn't we also have mariaDB on travis?

@Grotax
Copy link
Member

Grotax commented Sep 23, 2020

news/.travis.yml

Line 80 in 1f9db32

mariadb: "10.4"

seems like it, this is the commit before we introduced your new actions approach

@Grotax
Copy link
Member

Grotax commented Sep 23, 2020 •
edited
Loading

Also this limit which is there in the query has been there for 6 years now according to my editor
As far as I understood that mariadb packe we use if we don't pass a version it will use latest.

Maybe they removed the support for limits in inner queries at some point.

We should really get rid of manual sql statements at some point.

@SMillerDev
Copy link
Contributor Author

That's what the other pull request is for 😅

@SMillerDev
Copy link
Contributor Author

LGTM

@Grotax
Copy link
Member

Grotax commented Sep 24, 2020

Well many thanks to @Talon24 for helping us for the second time to fix an SQL issue 😁

@Grotax
Copy link
Member

Grotax commented Sep 24, 2020

How do I summarize this for the changelog? 😁

@SMillerDev
Copy link
Contributor Author

"Drop support for nextcloud versions before 20"

@Grotax Grotax merged commit 66ce13a into nextcloud:master Sep 25, 2020
@Grotax
Copy link
Member

Grotax commented Sep 27, 2020

Tried this new version but failed at the upgrade see #800

@SMillerDev SMillerDev deleted the require_20 branch September 27, 2020 14:04
@Grotax Grotax mentioned this pull request Sep 29, 2020
Merged
Grotax added a commit that referenced this pull request Sep 29, 2020
@Grotax
Release 15.0.0
60c2813 
Changed

- Update feed-io to v4.7.9
- Feed autodiscovery #806
- Drop support before nextcloud 20 #794
- Move to modern SQL syntax #750
- Add management commands #804 #750

Signed-off-by: Benjamin Brahmer <[email protected]>
Neo11 pushed a commit to Neo11/news that referenced this pull request May 28, 2022
@Grotax
Release 15.0.0
418b489 
Changed

- Update feed-io to v4.7.9
- Feed autodiscovery nextcloud#806
- Drop support before nextcloud 20 nextcloud#794
- Move to modern SQL syntax nextcloud#750
- Add management commands nextcloud#804 nextcloud#750

Signed-off-by: Benjamin Brahmer <[email protected]>
perrinjerome added a commit to perrinjerome/news-updater that referenced this pull request Oct 13, 2023
@perrinjerome
update README regarding how to set useCronUpdates
1bdf302 
Since nextcloud/news#794 this is in nextcloud
config
@perrinjerome perrinjerome mentioned this pull request Oct 13, 2023
Open
perrinjerome added a commit to perrinjerome/news-updater that referenced this pull request Oct 13, 2023
@perrinjerome
update README regarding how to set useCronUpdates
824fef3 
Since nextcloud/news#794 this is in nextcloud
config

Signed-off-by: Jérome Perrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grotax Grotax Grotax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SMillerDev @Grotax