update nextcloud-vue v8 #2861
Merged
update nextcloud-vue v8 #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wolfgang <[email protected]>
wofferl
added
dependencies
|
Wow, great work! |
|
I’ll try to take a look at the unit tests tomorrow.
…On Thu, Nov 7, 2024 at 12:28 PM Sean Molenaar ***@***.***> wrote:
Wow, great work!
—
Reply to this email directly, view it on GitHub
<#2861 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPKTWHHZSOJPPED3P2P3DZ7PEQJAVCNFSM6AAAAABRLZSTXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTGE2TCMZUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
devlinjunker
reviewed
Nov 9, 2024
| @@ -146,7 +145,9 @@ | |||
| "moduleNameMapper": { | |||
| "^@/(.*)$": "<rootDir>/src/$1", | |||
| "^Components/(.*)$": "<rootDir>/src/components/$1", | |||
| "^.+\\.(css|less|svg)$": "<rootDir>/tests/javascript/helpers/CSSStub.js" | |||
| "^.+\\.(css|less|svg)$": "<rootDir>/tests/javascript/helpers/CSSStub.js", | |||
| "^unist-util-visit$": "<rootDir>/tests/javascript/helpers/unist-stub.js", | |||
There was a problem hiding this comment.
this seems like the easiest solution to me, good fix!
There was a problem hiding this comment.
this seems like the easiest solution to me, good fix!
@devlinjunker thanks for the review
devlinjunker
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2503
Summary
In preparation for alternative view modes like compact or hopefully the old non-compact mode an update to nextcloud-vue v8 is needed.
This enables the use of different layouts for NcAppContent (
vertical-,horizontal-andno-split).no-splitcame with nextcloud-vue 8.10.0,hoizontal-splitwith 8.11.0.The needed changes were straightforward (nextcloud-libraries/nextcloud-vue#4223).
There are small visible changes:
Light theme v7:
Light theme v8:
Dark theme v7:
Dark theme v8:
Unit test problem (js-test)
The new library causes a problem with the unit-test (jest), which I bypassed with moduleNameMapper in package.json.
The problem seems that the new libraries have a wrapper and use the commonjs (.cjs) or esm (.mjs) version depending the import. The included library from the nextcloud-vue unist-util-visit only uses esm.
Besides the fact that the news app uses esm the jest tool uses commonjs and include the .cjs files, which results in the error
SyntaxError: Unexpected token 'export'(see new stub file tests/javascript/helpers/unist-stub.js).ESM support in jest would be experimental ECMAScript Modules
Maybe @devlinjunker has more insights here and can check if my way to workaround is ok, because I'm not really familiar with the javascript unit tests yet.
Checklist