FeedFetcher: Use feeds logo instead of the favicon

[Grotax]

This changes the behavior of fetching the favicon, since feed-io offers to get the feeds logo, we try to get that first, then fall back to the favicon.

I didn't change the var name, I'm not sure if we should do that. But that would include API changes if I'm not wrong.

Also I want to test this first.

[SMillerDev]

I think this should also have a unittest associated with it.

[anoymouserver]

Not sure if that's good idea to use it as the favicon in front of a feed. According to the Atom standard the logo has the aspect ratio of 2:1 and the RSS standard seems to also prefer a non-square image.

[Grotax]

@anoymouserver I doubt that anyone adheres to it, the only feed I found didn't it was simply the wordpress 32x32 favicon
Also I think clients should be able to handle it if it happens

[Grotax]

I would also love to increase the size of the favicons we can pull, but thats not supported by the lib

[anoymouserver]

I would also love to increase the size of the favicons we can pull, but thats not supported by the lib

Wouldn't it be better then to extend the 3rd-party lib to prefer higher resolutions (or even better SVGs) (ArthurHoaro/favicon#12)?

[Grotax]

I would also love to increase the size of the favicons we can pull, but thats not supported by the lib

Wouldn't it be better then to extend the 3rd-party lib to prefer higher resolutions (or even better SVGs) (ArthurHoaro/favicon#12)?

I think I would prefer that, as it would bring an improvement to almost all feeds.
But I also think that it's not easy, the only standard I know is the one apple introduced at some point.

[anoymouserver]

Could we check if the feed's logo is square and if not, just use the favicon?
I'll eventually have a look if we can query bigger sizes or even better SVG favicons.

[Grotax]

@anoymouserver sounds good I will check how to do that.

[Grotax]

Do we want to check the aspect ratio every time we build the feed, like this?

If yes I will try to fix the unit tests

[Grotax]

I will manually squash the commits before merging

[SMillerDev]

Just some nitpicks. Feature looks good.

[codecov-io]

Codecov Report

Merging #1164 (f62a871) into master (961c561) will decrease coverage by 0.38%.
The diff coverage is 54.54%.

@@             Coverage Diff              @@
##             master    #1164      +/-   ##
============================================
- Coverage     91.34%   90.96%   -0.39%     
- Complexity      662      665       +3     
============================================
  Files            57       57              
  Lines          2358     2369      +11     
============================================
+ Hits           2154     2155       +1     
- Misses          204      214      +10     

Impacted Files	Coverage Δ	Complexity Δ
lib/Fetcher/Fetcher.php	100.00% <ø> (ø)	5.00 <0.00> (ø)
lib/Service/FeedServiceV2.php	100.00% <ø> (ø)	28.00 <0.00> (ø)
lib/Fetcher/FeedFetcher.php	88.23% <52.38%> (-6.89%)	36.00 <7.00> (+3.00)	⬇️
lib/Command/ShowFeed.php	100.00% <100.00%> (ø)	4.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 961c561...f62a871. Read the comment docs.