Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/option persistence #504

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fix/option persistence #504

merged 2 commits into from
Aug 3, 2023

Conversation

Leptopoda
Copy link
Member

@Leptopoda Leptopoda commented Jul 19, 2023 •
edited
Loading

Forgot to push this earlier.
Fixes the loading of SelectOption value when no values have been set yet.

@Leptopoda
Copy link
Member Author

Still missing a unit test

@Leptopoda
Copy link
Member Author

I couldn't test/verify the updated branch yet.

@Leptopoda
Copy link
Member Author

@provokateurin I verified it with the initial app option

@Leptopoda Leptopoda merged commit 6205e9d into main Aug 3, 2023
2 checks passed
@Leptopoda Leptopoda deleted the fix/option_persistence branch August 3, 2023 06:49
@provokateurin
Copy link
Member

The news app "How to open article" option is still broken :/

@Leptopoda
Copy link
Member Author

I'll take a look 😅

@provokateurin
Copy link
Member

But other options in the news settings seem fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leptopoda @provokateurin