Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tool): Use host network for dev container #2601

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

provokateurin
Copy link
Member

I've been experience DNS issues within the docker quite a few times and using the host network fixes it reliably.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.84%. Comparing base (043e219) to head (30f207f).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2601   +/-   ##
=======================================
  Coverage   28.84%   28.84%           
=======================================
  Files         370      370           
  Lines      136488   136488           
=======================================
  Hits        39369    39369           
  Misses      97119    97119           
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø)
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø)
dynamite_end_to_end_test 61.69% <ø> (ø)
dynamite_runtime 85.40% <ø> (ø)
interceptor_http_client 97.18% <ø> (ø)
neon_dashboard 96.05% <ø> (ø) Carriedforward from 043e219
neon_framework 61.11% <ø> (ø)
neon_http_client 97.50% <ø> (ø)
neon_notifications 100.00% <ø> (ø) Carriedforward from 043e219
neon_storage 94.66% <ø> (ø)
neon_talk 99.45% <ø> (ø) Carriedforward from 043e219
nextcloud 24.32% <ø> (ø)
notifications_app 97.40% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø)
talk_app 98.94% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@provokateurin provokateurin merged commit ab8f54f into main Oct 31, 2024
10 checks passed
@provokateurin provokateurin deleted the fix/tool/dev-container-host-network branch October 31, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants