Merge pull request #524 from Leptopoda/fix/news_option_persistence

fix(neon_news): NewsAppSpecificOptions.articleViewTypeOption persistence
nextcloud · Aug 4, 2023 · 706a0ba · 706a0ba
2 parents 185f749 + 6cde774
commit 706a0ba
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/packages/neon/neon_news/lib/options.dart b/packages/neon/neon_news/lib/options.dart
@@ -1,7 +1,7 @@
 part of 'neon_news.dart';
 
 class NewsAppSpecificOptions extends NextcloudAppOptions {
-  NewsAppSpecificOptions(super.storage, final NeonPlatform platform) {
+  NewsAppSpecificOptions(super.storage, this._platform) {
     super.categories = [
       generalCategory,
       articlesCategory,
@@ -21,18 +21,10 @@ class NewsAppSpecificOptions extends NextcloudAppOptions {
       feedsSortPropertyOption,
       feedsSortBoxOrderOption,
     ];
-
-    articleViewTypeOption.values = {
-      ArticleViewType.direct: (final context) => AppLocalizations.of(context).optionsArticleViewTypeDirect,
-      if (platform.canUseWebView) ...{
-        ArticleViewType.internalBrowser: (final context) =>
-            AppLocalizations.of(context).optionsArticleViewTypeInternalBrowser,
-      },
-      ArticleViewType.externalBrowser: (final context) =>
-          AppLocalizations.of(context).optionsArticleViewTypeExternalBrowser,
-    };
   }
 
+  final NeonPlatform _platform;
+
   final generalCategory = OptionsCategory(
     name: (final context) => AppLocalizations.of(context).general,
   );
@@ -68,7 +60,14 @@ class NewsAppSpecificOptions extends NextcloudAppOptions {
     key: 'article-view-type',
     label: (final context) => AppLocalizations.of(context).optionsArticleViewType,
     defaultValue: ArticleViewType.direct,
-    values: {},
+    values: {
+      ArticleViewType.direct: (final context) => AppLocalizations.of(context).optionsArticleViewTypeDirect,
+      if (_platform.canUseWebView)
+        ArticleViewType.internalBrowser: (final context) =>
+            AppLocalizations.of(context).optionsArticleViewTypeInternalBrowser,
+      ArticleViewType.externalBrowser: (final context) =>
+          AppLocalizations.of(context).optionsArticleViewTypeExternalBrowser,
+    },
   );
 
   late final articleDisableMarkAsReadTimeoutOption = ToggleOption(