refs #85 fix bug with unnamed contacts

[julien-nc]

I guess this should do it.

[tacruc]

Maybe not ??? but an empty string?

[julien-nc]

Well I don't want to face other problems like generating an avatar image for an empty string etc...

[tacruc]

Ok

[tacruc]

I found why there is no FN attribute, the cards just have the N attribute.

[julien-nc]

Wait, shouldn't we read 'N' when 'FN' is not set? What does the 'N' field contain?

[julien-nc]

What do you think about something like

'FN'=>$c['FN'] ?? $c['N'] ?? '???',

?

[tacruc]

private function N2FN(string N) {
  return explode(N,';')[3]+explode(N,';')[1]+explode(N,';')[0]
}

'FN'=>$c['FN'] ?? $this->N2FN($c['N']) ?? '???',

[julien-nc]

I can't understand what you wrote unless you explain what's inside 'N' field.

[tacruc]

Doe;John;;Dr;
taken from https://en.m.wikipedia.org/wiki/VCard#Properties

[julien-nc]

Ok and do you know when/why 'N' is set and 'FN' is not?

[tacruc]

Its an address book I created by importing an CSV file with kaddressbook. It might be an error in the import process.

[jancborchardt]

Maybe @skjnldsv from @nextcloud/contacts can help with that Contacts-related question? :)

[julien-nc]

Well then N2FN could be more secure by verifying the explode gives at least 4 elements. It could be called once and put in a variable too.

Do we agree on something like:

private function N2FN(string $n) {
  if ($n) {
    $spl = explode($n,';');
    if (count($spl) >= 4) {
      return $spl[3] + $spl[1] + $spl[0];
    }
    else {
      return null;
    }
  }
  else {
    return null;
  }
}

'FN'=>$c['FN'] ?? $this->N2FN($c['N']) ?? '???',

?

[tacruc]

Looks good, we probably need to add some spaces between the parts.

[julien-nc]

Could you give it a little try?

[jancborchardt]

Briefly tested and seems good, but I can’t judge the code.