fix declaration of object_uri DB field #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <[email protected]>
tacruc
approved these changes
Sep 25, 2020
|
@eneiluj: Do you intend to backport this to the Nextcloud 19 release as well? Version 19.0.4 has been released and installing |
aszlig
added a commit
to aszlig/avonc
that referenced
this pull request
Oct 10, 2020
Since Nextcloud 19.0.4.2, database columns that are non-null can no longer contain a default of empty string. This also has been addressed upstream[1], but Nextcloud 19 currently gets maps version 0.1.6, which does not yet contain this fix. nextcloud/maps#453 Signed-off-by: aszlig <[email protected]>
This was referenced Nov 22, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was making the installation crash on instance where Maps was never installed (all migration scripts running).
Strange that we didn't bump into that earlier. Anyway, old migration scripts run fine on fresh install now.
object_uricolumn is always affected when inserting/updatingmaps_address_geotable anyway.