Added sidebar to the viewer #418
Conversation
Signed-off-by: Arne Hamann <[email protected]>
There was a problem hiding this comment.
Very nice! I didn't know it was possible to embed the Files sidebar!
Just a few minor changes and we can merge.
Oh and also, we get 3 Javascript errors on page load:
Uncaught TypeError: can't access property "extend", OCA.Files.DetailTabView is undefined
Uncaught TypeError: can't access property "Client", t.Files is undefined
Uncaught TypeError: can't access property "extend", OCA.Files.DetailTabView is undefined
src/photosController.js
Outdated
| @@ -205,7 +207,7 @@ PhotosController.prototype = { | |||
| iconUrl = _app.getImageIconUrl(); | |||
| } | |||
| var label = cluster.getChildCount(); | |||
| if( availZoomLevels == 0 && label > 1){ | |||
| if( availZoomLevels == 0 && label > 1){ | |||
There was a problem hiding this comment.
Could you also remove those changes on trailing white spaces? Or maybe fix the code style in this file?
This line could be:
if (availZoomLevels === 0 && label > 1) {
I thing the errors are a problem we are not going to solve now. They happen for the photos app, too. I think it is related to different tabs which are not yet migrated. |
|
Ok so ready to merge after having removed the |
Signed-off-by: Arne Hamann <[email protected]>
Yep, you can ignore those :) |
Signed-off-by: Arne Hamann [email protected]