Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codestyle workflows and fixer #1325

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Add codestyle workflows and fixer #1325

merged 10 commits into from
Sep 16, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 14, 2024

  • Add php-cs-fixer as a dev dependency
  • Run it on the codebase
  • Add workflows to check code style
  • Ignore the code fixing commit in git blame

@come-nc come-nc requested review from susnux and julien-nc September 14, 2024 18:29
@come-nc come-nc self-assigned this Sep 14, 2024
@susnux
Copy link
Contributor

susnux commented Sep 14, 2024

Need rebase and git blame ignore update

@come-nc
Copy link
Contributor Author

come-nc commented Sep 15, 2024

Need rebase and git blame ignore update

Why? I can just merge, no?

@come-nc come-nc merged commit a3da881 into master Sep 16, 2024
21 checks passed
@come-nc come-nc deleted the fix/add-workflows branch September 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@susnux susnux susnux approved these changes

Assignees

@come-nc come-nc

Labels
3. to review technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @susnux @julien-nc