Scan photos of specific directory

[tetebueno]

I've been getting memory exhaustion when scanning all photos collection on an initial load; trying to address #525 I made these changes and was able to scan each year/month directory of photos succesfully like this (the example is for the folder with photos of july '84):

$ docker exec -t -u www-data container-name php occ maps:scan-photos -vvv username Photos/1984/06

I didn't like the ifs all over the implementation, but it's something like a make it work approach. If I can get comments about it, we can make it better.

Cheers.

[tacruc]

Thanks for your contribution. Can you pass the path as optional argument?
Do you need help to fix the DCO?

[tetebueno]

You are very welcome.

Done with DCO, thanks.

Is there anything else besides this so the path parameter is optional? I believe it already is since help command displays it like this: ... [<user_id> [<path>]].

[tacruc]

Hi @tetebueno,
sorry for the late reply and beeing a little unprecise.
I mean in stead of adding the functions
RescanPhotos->scanUserPhotos
and
PhotofilesService->rescanPath

Just provide an optional parameter to

       private function rescanUserPhotos(string $userId, bool $inBackground=true, sting? $pathToScan===null) {

and PhotofilesService
public function rescan($userId, $inBackground=true, $pathToScan=null) {

and then make an if in the Photofilesservice->rescan

$userFolder = $this->root->getUserFolder($userId)
if ($pathToScan === null) {
          $folder = $userFolder
} else {
          $folder = $userFolder->get($pathToScan);
}
$photos = $this->gatherPhotoFiles($folder, true);

Don't blindly copy my code. It is just typed in here to outline my thought and not tested.

[tacruc]

@tetebueno Do you think you will make the changes befor the NC29 release. Then I would wait with #1244 to include this.

I'm sorry that it is on such short notice after not reviewing for a month. Just have to decide whether to wait or not.

[marlemion]

I just wanted to bring this back to mind. In my case it is tedious to update ~100000 Pictures just to get some recently geotagged pictures into Maps....

[tetebueno]

Apologies to everyone. Totally forgot about this.

@tacruc, I'm not completely sure what does this line do in RescanPhotos+rescanUserPhotos(), but I tried to maintain the logic intended in the first PR version:

$this->config->setUserValue($userId, 'maps', 'installScanDone', 'yes');

[tetebueno]

Forgot DCO again and it seems I went too far with it double-signing-off everything.

[tetebueno]

Ok, my bad, tried merging with Github's visual tool and it was an indentation mess challenge. Will take care of this as soon as I can.

[tetebueno]

Finally got some time to pull this to a local environment and merge and fix formatting issues. Hope this is it.

[danotrampus]

Also waiting for this... Any news?

[tacruc]

@tetebueno Thanks alot for your contribution. I will see if I find time the next two weeks to publish them. But I cannot promise it.

[tetebueno]

Gaaa, just got a chance to run composer run cs:fix and pushed the fixed code. Thanks anyway. I'm available for any issues regarding this.