Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "Download Track" button to AppNavigationTrackItem #1147

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

wronny
Copy link
Member

@wronny wronny commented Oct 20, 2023

Hello,
first of all congrats to many great improvements in maps. I like and use creating maps and sharing them. Due to the fact that I use it for sharing tracks I added a "Download Track" button, to being able to provide all in one share link.
Please review and merge if you like/agree on it.
Thanks
Marcel

Copy link
Collaborator

@tacruc tacruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wronny,
Thanks for the feedback and your contribution.
I like the download in the app navigation.
What do we need a download link in the track right-click menu? Or In The track metadata tab?

@wronny
Copy link
Member Author

wronny commented Oct 20, 2023

Hello @tacruc ,
Not sure if I got you correctly. Do you want me to add the track download button in the track right-click menu, too? I can add this as well if you want. Just let me know.

@tacruc
Copy link
Collaborator

tacruc commented Oct 21, 2023

First I wanted your opinion on it.
I think it might be useful, but maybe you thought already about it and had a reason against it.

@wronny
Copy link
Member Author

wronny commented Oct 21, 2023

Hello @tacruc,
I agreee. Adding it also to the track's right click menu makes sense.
Added to this pull request, now. However looks like close-after-click does not work in this track context menu. Added auto close via click method, like also used for "Display elevation".

@tacruc tacruc enabled auto-merge October 23, 2023 07:16
@tacruc tacruc disabled auto-merge October 23, 2023 07:20
@tacruc tacruc enabled auto-merge October 23, 2023 07:20
@tacruc tacruc merged commit 5cb5b0a into master Oct 23, 2023
9 checks passed
@tacruc tacruc deleted the track-menu-download-button branch October 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants