Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #1094

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Misc fixes #1094

merged 3 commits into from
Jul 3, 2023

Conversation

alaskanpuffin
Copy link
Contributor

Changes

  • Fixes confirmation message when saving a favorite with no name
  • Adds a favicon and proper format for app icon

The favicon should theoretically work, although it's not showing up on my test instance. I don't know if it's a caching issue or what. It's setup according to the docs here: https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/theming.html

Sorry about all the pull requests. I've gotten on a bit of a roll fixing small issues. Haha

Signed-off-by: Alaskan Puffin <[email protected]>
@tacruc
Copy link
Collaborator

tacruc commented Jul 3, 2023

@alaskanpuffin Don't worry about the Pro's, I love it.

@tacruc tacruc enabled auto-merge July 3, 2023 09:08
@tacruc tacruc merged commit 3027c6d into nextcloud:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants