Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some GPX Tracks not visible #738

Closed
Tracked by #732
nougatbyte opened this issue Jun 1, 2022 · 14 comments · Fixed by #739
Closed
Tracked by #732

Some GPX Tracks not visible #738

nougatbyte opened this issue Jun 1, 2022 · 14 comments · Fixed by #739

Comments

@nougatbyte
Copy link

Some GPX tracks dont get rendered on the map even when enabled.

Example GPX File that doesnt work: https://github.com/gps-touring/sample-gpx/blob/master/RoscoffCoastal/1_Roscoff_Morlaix_A_parcours.gpx

Example GPX File that works:
working.zip

like in my last issue, I‘m pretty sure this worked on an older version.

@tacruc
Copy link
Collaborator

tacruc commented Jun 2, 2022

Could you confirm that the track is shown, if the time slider is disabled?

@nougatbyte
Copy link
Author

nougatbyte commented Jun 2, 2022

@tacruc can you please tell me where to find the timeslider? The nearest thing I could find was the elevation display.

edit: nvm, just seen your pull request now, will test

@tacruc
Copy link
Collaborator

tacruc commented Jun 2, 2022

In the navigation sidebar at the bottom under settings. (Lower left corner)

@nougatbyte
Copy link
Author

If the time slider is disabled I can only see the start point of the gpx track.
If the slider is enabled the point disappears.

Expected behaviour would be the rendering of the track like in gpsvisualizer.com:
image

@tacruc
Copy link
Collaborator

tacruc commented Jun 2, 2022

I'm confused.
Are you still talking about the master branch or about the changes in #739?
I would suggest that we discuss the original issue here and the changes in the pull request.

@nougatbyte
Copy link
Author

Sorry, I had no time checking out this pull request - everything I described until now was on the master branch from a few days ago.

I will try to write a more detailed answer this evening.

@tacruc
Copy link
Collaborator

tacruc commented Jun 2, 2022

Ok because I had what you described in an intermediate version of the fix, and was unsure if I just pushed the wrong state.

@nougatbyte
Copy link
Author

nougatbyte commented Jun 3, 2022

I was now able to test the branch.
Sadly it doesnt seem to fix the issue.
Screenshots of how it looks for me:
1
2

In the second image the starting point of the track is visible but not its trackpoints like in the example in #738 (comment)

@tacruc
Copy link
Collaborator

tacruc commented Jun 3, 2022

After changing the branch did you rebuild the js code by running:
npm ci?

@tacruc tacruc mentioned this issue Jun 7, 2022
18 tasks
@nougatbyte
Copy link
Author

Tried it now with npm ci in the AllwaysShowTracksWithoutTimestamps branch, sadly still like in #738 (comment)

@tacruc
Copy link
Collaborator

tacruc commented Jun 7, 2022

Hm interesting, I have serious problems to reproduce this with the AllwaysShowTracksWithoutTimestamps branch:
image
image
While I have the behavior from #738 (comment) with master.
Could you try npm run watch additionally?

@nougatbyte
Copy link
Author

Nice! It works with npm run watch. As I understand it run watch should do the same just with hot reloading right?
Is there any way I could have cleared any caches to instantly see changes?

@tacruc
Copy link
Collaborator

tacruc commented Jun 7, 2022

Maybe Ctrl + F5

tacruc added a commit that referenced this issue Jun 7, 2022
…amps

Allways show tracks without timestamps
Review see #738
@nougatbyte
Copy link
Author

Already tried Hard reloading, Ill just try with run watch next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants