Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: link checking for phishing detection #9994

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Feat: link checking for phishing detection #9994

merged 1 commit into from
Aug 13, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Aug 13, 2024 •
edited
Loading

part of #9453

1 2
image image

@hamza221 hamza221 added enhancement 3. to review skill:backend Issues and PRs that require backend development skills labels Aug 13, 2024
@hamza221 hamza221 self-assigned this Aug 13, 2024
@hamza221 hamza221 mentioned this pull request Aug 13, 2024
Closed
17 tasks
ChristophWurst
ChristophWurst approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

I'd really love to see a bit of test coverage for the new check

I'm okay with merging without to meet the branch-off and backport the tests in the near future

@hamza221 hamza221 merged commit 3f0a1b1 into main Aug 13, 2024
28 of 29 checks passed
@hamza221 hamza221 deleted the feat/link-checking branch August 13, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski

Assignees

@hamza221 hamza221

Labels
3. to review enhancement skill:backend Issues and PRs that require backend development skills
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza221 @ChristophWurst @miaulalala