Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use whole certificate chain for S/MIME signing/verification - take 2 #9677

Merged
merged 1 commit into from
May 28, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented May 28, 2024

Upload whole certificate chain when uploading a certificate for S/MIME in pkcs12 format. Include whole certificate chain in signed messages. Use whole certificate chain to verify certificates.

Fixes #9190

Continuation of #9665

Upload whole certificate chain when uploading a certificate for S/MIME in pkcs12 format. Include whole certificate chain in signed messages. Use whole certificate chain to verify certificates.

Fixes #9190

Signed-off-by: Patrick Bender <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added bug 3. to review feature:smime For all tasks related to S/MIME labels May 28, 2024
@st3iny st3iny added this to the v3.7.0 milestone May 28, 2024
@st3iny st3iny self-assigned this May 28, 2024
Copy link
Member Author

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

See my review1 in the other PR. This PR here exists solely to get green CI.

Footnotes

  1. https://github.com/nextcloud/mail/pull/9665#pullrequestreview-2083621173

@st3iny
Copy link
Member Author

st3iny commented May 28, 2024

/backport to stable3.6

@st3iny st3iny merged commit 52a2ef9 into main May 28, 2024
34 of 35 checks passed
@st3iny st3iny deleted the fix/smime/cert-chain branch May 28, 2024 19:16
@ChristophWurst
Copy link
Member

/backport to stable3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature:smime For all tasks related to S/MIME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextcloud mail 3.5.0 generates invalid smime signature
3 participants