Fix the overlapping of primary menu with recipient #8232
Conversation
src/components/ThreadEnvelope.vue
Outdated
| @delete="$emit('delete',envelope.databaseId)" /> | ||
| <NcActions /> | ||
| </ncactions> |
There was a problem hiding this comment.
| @delete="$emit('delete',envelope.databaseId)" /> | |
| <NcActions /> | |
| </ncactions> | |
| @delete="$emit('delete',envelope.databaseId)" /> | |
| </NcActions> |
GretaD
force-pushed
the
fix/primary-menu-threadEnvelope
branch
2 times, most recently
from
8fdcd5b
to
41bd86e
Compare
| :size="20" /> | ||
| </template> | ||
| <Fragment> | ||
| <template v-if="!moreActionsOpen"> |
There was a problem hiding this comment.
You still need the actions component wrapping the action items!
There was a problem hiding this comment.
this will just duplicate the primary actions outside the action menu, i have the actions on threadenvelope. And it was working fine, till i did the rebase and pulled on server.
There was a problem hiding this comment.
so the mystery is resolved thanks to Max, he figured it out that the problem was my rebase and a typo. I applied the wrong changes on my rebase attempt and my actions were not closed, thats why the stuff were floating around. All good now :)
GretaD
force-pushed
the
fix/primary-menu-threadEnvelope
branch
2 times, most recently
from
2e35d9c
to
ade0fb9
Compare
|
I would remove at least one more action, particularly if there is an "unsubscribe" option.
|
GretaD
force-pushed
the
fix/primary-menu-threadEnvelope
branch
from
ade0fb9
to
8af0fb6
Compare
Changed it, please have another look :) |
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
fix/primary-menu-threadEnvelope
branch
from
8af0fb6
to
19fbd4d
Compare
fixes #8191
Im trying to adapt text logic for mail: https://github.com/nextcloud/text/blob/8a17046aa440df841fe9182205d80ce937068c1a/src/components/Menu/MenuBar.vue
and also using inline prop that
NcActionsusesScreencast.from.08.05.2023.19.06.28.webm