Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the icon-collapse to align left #7856

Closed
wants to merge 1 commit into from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jan 2, 2023

fixes: #7095

This is an old bug. Most probably this should be fixed on nc/vue but i dont see which change caused this error there. This error can be caused also from some server css, but so far i failed to find the right change, so pushing this pr till we figured it out.
before
Screenshot from 2023-01-02 18-09-13
after
Screenshot from 2023-01-02 18-08-52

@GretaD
Copy link
Contributor Author

GretaD commented Jan 2, 2023

@juliushaertl i added you as a reviewer since this error is also happening on deck: nextcloud/deck#4352

@juliusknorr
Copy link
Member

I think I found a potential upstream fix. Looks like this only works in the vue component docs because the button style is loaded after the NcAppNavigationIconCollapsible one. Will push something shortly.

@juliusknorr
Copy link
Member

nextcloud-libraries/nextcloud-vue#3608 works with deck, so likely also fixes the issue for mail

@GretaD
Copy link
Contributor Author

GretaD commented Jan 3, 2023

I think I found a potential upstream fix. Looks like this only works in the vue component docs because the button style is loaded after the NcAppNavigationIconCollapsible one. Will push something shortly.

testing in a bit, thank you so much <3

@GretaD
Copy link
Contributor Author

GretaD commented Jan 3, 2023

tested and it works with Julius pr 🥳

@GretaD GretaD closed this Jan 3, 2023
@st3iny st3iny deleted the fix/appnavigationitem-with-children branch January 4, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation expand icon moved to the right
2 participants