Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement automatic out-of-office replies #7102

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Implement automatic out-of-office replies #7102

merged 1 commit into from
Sep 2, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 30, 2022 •
edited
Loading

Fix #5441

To-do

  • UI skeleton
  • Write the script
  • Read metadata to restore UI state
  • Fill out :addresses ["[email protected]", "[email protected]"] from account email and aliases so no emails to mailing lists get auto-responded (has to be implemented; the mail server won't send a single response)

To-do from design review

Vacation responder review

  • Sorting of settings sections
    • …
    • Vacation responder
    • Filter rules
    • Trusted senders
    • Mail server
    • Filter server
  • Wording detail: "Out of office replies" → "Vacation responder"
  • Heading subline in color-text-maxcontrast: "Automated reply to incoming messages. If someone sends you several messages, this automated reply will be sent at most once every 4 days."
  • "Vacation responder on" and "Vacation responder off"
  • "Last day" → "Last day (optional)"
  • Default "Last day" always +6 days from "First day"
  • Ensure that last day is always after first day (either keep the previous distance, or if difficult, just use +6 here as well)
  • Message field is a bit large, reduce to 100px default
  • When not enabled, set all fields to "disabled" instead of hiding all
  • Make sure that Subject and Message are saved even when disabled
  • "Save" → "Save vacation responder"
  • Filter rule needs to have individual heading/comment box probably? Not generic Don’t edit above … but rather ### Nextcloud Mail: Vacation responder DO NOT EDIT! ###

Out of scope for now

  • Supporting rich formatting in vacation responder
  • Checkbox like Gmail "Only send a response to people in my Contacts" – also for privacy reasons, so not everyone knows you are away
  • Ability to add vacation replacement via account picker
  • Connecting with Nextcloud Status feature
  • Adding the dates to the message programmatically

@st3iny st3iny self-assigned this Aug 30, 2022
@ChristophWurst

This comment was marked as resolved.

Sign in to view
@ChristophWurst

This comment was marked as resolved.

Sign in to view
@st3iny st3iny force-pushed the enh/5441/ooo branch 5 times, most recently from 08ebf40 to 26260fa Compare September 2, 2022 11:11
ChristophWurst
ChristophWurst reviewed Sep 2, 2022
View reviewed changes
src/store/actions.js Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 2, 2022 •
edited
Loading

  • Enabling Sieve for a new account and then going to OOO right away

Weirdly cut off modal
Bildschirmfoto vom 2022-09-02 15-35-38

OOO section is empty
Bildschirmfoto vom 2022-09-02 15-35-55

Related?

Bildschirmfoto vom 2022-09-02 15-37-27

@st3iny st3iny marked this pull request as ready for review September 2, 2022 14:15
@st3iny
Copy link
Member Author

st3iny commented Sep 2, 2022

  • Enabling Sieve for a new account and then going to OOO right away

I have no clue what is happening here. Even if I remove the v-if condition from OutOfOfficeForm this still happens. I can only reproduce it in Firefox with a small vertical resolution. Resizing the window also fixes the problem immeediately.

ChristophWurst
ChristophWurst approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with a few rendering quirks on FF

Nit: last day should probably have a min of the first day

@ChristophWurst
Copy link
Member

eslint, squash and let's go :shipit:

@kesselb
Copy link
Contributor

kesselb commented Sep 2, 2022 •
edited
Loading

  • Escape quotes (and eventually other) characters.

image

@kesselb
Copy link
Contributor

kesselb commented Sep 2, 2022 •
edited
Loading

  • Remove marker from Subject and Message
Screencast.from.02.09.2022.18.09.35.webm

kesselb
kesselb reviewed Sep 2, 2022
View reviewed changes
src/components/OutOfOfficeForm.vue

<fieldset class="form__fieldset">
<label for="ooo-message">{{ t('mail', 'Message') }}</label>
<TextEditor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6935 changes TextEditor heavily. I recommend to use <textarea> for now ;)

kesselb
kesselb approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

Should be okay to address "Escape quotes (and eventually other) characters" and "Remove marker from Subject and Message" later.

@ChristophWurst
Copy link
Member

Remove marker from Subject and Message

If someone breaks the OOO replies like that they deserve a broken Sieve script

@kesselb
Copy link
Contributor

kesselb commented Sep 2, 2022

  • Newlines are lost 😨
Screencast.from.02.09.2022.19.09.57.webm

(not a blocker. looks like a visual bug as the newlines are there in the sieve script)

@kesselb
Copy link
Contributor

kesselb commented Sep 2, 2022

If someone breaks the OOO replies like that they deserve a broken Sieve script

Got another one for you 🤣

Screencast.from.02.09.2022.19.12.13.webm

@kesselb
Copy link
Contributor

kesselb commented Sep 2, 2022

Screencast.from.02.09.2022.19.14.16.webm

https://github.com/thsmi/sieve cannot parse our sieve script into the graphical view :(

@ChristophWurst
Copy link
Member

Conflicts 😬

@st3iny @ChristophWurst
Implement automatic out-of-office replies
5371675 
Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
ChristophWurst approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

@ChristophWurst
Copy link
Member

  • BUG if I enter 2022-08-28 as start and end date it becomes 2022-08-29 after saving?!

@ChristophWurst ChristophWurst merged commit efd3880 into main Sep 2, 2022
@ChristophWurst ChristophWurst deleted the enh/5441/ooo branch September 2, 2022 17:51
@ChristophWurst ChristophWurst added this to the v2.0.0 milestone Sep 2, 2022
@st3iny st3iny mentioned this pull request Sep 6, 2022
Closed
5 tasks
@ChristophWurst ChristophWurst mentioned this pull request Sep 7, 2022
Closed
@ChristophWurst ChristophWurst mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Assignees

@st3iny st3iny

Labels
3. to review enhancement feature:integration feature parity
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Automatic out-of-office replies
3 participants
@st3iny @ChristophWurst @kesselb