Log slow MySQL queries on CI #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
chore/mysql-slow-query-logs
branch
from
ecf863e
to
66d2974
Compare
ChristophWurst
commented
Feb 18, 2022
| - name: Enable slow mysql query logs | ||
| if: ${{ matrix.db == 'mysql' }} | ||
| run: | | ||
| echo "SET GLOBAL log_queries_not_using_indexes = 1;" | mysql -h 127.0.0.1 -u root -pmy-secret-pw |
There was a problem hiding this comment.
on CI queries aren't slow enough to trigger a slow query as per https://mariadb.com/kb/en/slow-query-log-overview/, so I've added this line to show anything that doesn't use an index.
There was a problem hiding this comment.
Any clue if that shows queries where an index exists but is not used because it matches 90% of the rows anyway and stuff like this?
There was a problem hiding this comment.
That is indeed the case. So if your tests clear a table with DELETE FROM xyz it will show up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us with #5835