Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inline images in editor #4893

Closed
wants to merge 3 commits into from

Conversation

StCyr
Copy link
Collaborator

@StCyr StCyr commented Apr 4, 2021

fixes #2052

(based on branch enhancement/rework-duplicate-entries-for-tag-message since master doesn't work for me atm)

TODO

  • ckeditor magic with a custom uploader that uploads to our temporary attachment storage
  • a route that serves images of those temporary files
  • logic that changes from the temporary URL source to a part when the message is sent

If someone wants to help me, he/she's most welcome 😃

@StCyr StCyr added enhancement 2. developing feature:editor All bugs, features and pull requests about the (HTML) editor labels Apr 4, 2021
@StCyr StCyr self-assigned this Apr 4, 2021
@StCyr StCyr force-pushed the feature/add-image-support-to-editor branch from 7c183a0 to 3582794 Compare April 4, 2021 22:55
@miaulalala
Copy link
Contributor

@StCyr master should be fixed now 👍

@ChristophWurst
Copy link
Member

Superseded by #6935 🚀

Thanks a ton for your effort @StCyr. It took us all a few attempts to get this feature done 🤞

@ChristophWurst ChristophWurst deleted the feature/add-image-support-to-editor branch December 20, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing enhancement feature:editor All bugs, features and pull requests about the (HTML) editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow image upload in HTML editor
3 participants