Feature: print email

[sourenaraya]

Fixes #579

new dependency introduced, not sure if that is ok.
Ctrl+P works.

[sourenaraya]

any update on review?

[ChristophWurst]

Let's wait for @jancborchardt's review

[sourenaraya]

Sorry for asking this again, but, any update on this?

[jancborchardt]

Sorry, I was recently on vacation and have to get up to speed again. :) Will check it soon. @sourenaraya just for clarification: There’s no interface change to check for, only Ctrl-P and browser menu print functionality, correct?

[sourenaraya]

Yep, just Ctrl+P as usual.

[jancborchardt]

Works very nicely, good job @sourenaraya! Only details:

• In Firefox: If you print via the menu → Print functionality you get a preview. If you scroll there, the mail-message-header (with subject, sender and recipient) is still sticky so floating above the text. Maybe it should be changed to position: relative; for printing? It does come out fine in the PDF
• Also in Firefox/Ubuntu, when printing to PDF, is it possible to preset the file name to something, like the mail title? For me the filename is always the same as last time unless I rename.
• In the printout, the date of the email is not included. Should we have this? Might be something for a follow-up too.

In general nothing blocking and we could also merge it like this 👍 :)

[sourenaraya]

i've set position: relative to mail-message-header, thanks.

• print-to-pdf function: AFAK there is no way to suggest filename to browser. Its always mozilla.pdf, or something set in about:config
• date in the printout: date is not present on plaintext, as well as on richtext emails, anywhere. First of all, we have to somehow include it in backend responses, or have a way to retrieve date information from backend. If there is any, i am not aware of it.

[jancborchardt]

Works very well, 👍 from me. :) Great job @sourenaraya! 🚀

[ChristophWurst]

There are a few edge cases with complex HTML emails but other than it works as advertised :)

Thanks a lot!

[ChristophWurst]

@sourenaraya please don't forget to go to https://www.bountysource.com/issues/50806693-print-stylesheet and claim your bounty :)

[sourenaraya]

Issue still marked as open on the bountysource 😂

[ChristophWurst]

Ugh. Bountysource is so buggy. Sorry about that. Tried to get support via https://twitter.com/ChristophWurst/status/1159344197436104704. Let's see 🙏